Port OrcaSlicer PR #3091: Practically full re-write of spiral vase #12142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vase Ported from commits: SoftFever/OrcaSlicer@9acd550 SoftFever/OrcaSlicer@522b848 Original commit messages: - Adds transition out to prevent sharp edge at the top of spiral vase. - Adds XY interpolation - Adds option to turn XY interpolation on/off * - Increasing E to 5 decimal digits (I observed uneven flow with less than that) - Excluding all travel moves (I saw a bug where somehow we ended up with travel moves within the print so excluding all travel moves) * - max_xy_smoothing is now configurable, default is 200% of nozzle_diameter - fixed no-op travel moves in the middle of spiral that now show up as defects when Smooth Spiral is enabled! * - Avoiding namespace pollution - Fixing dist_XY == 0 bug * Fixed a regression that non spiral vase mode was broken. Original commits authored by Andrew Boktor <aboktor@microsoft.com>, SoftFever <softfeverever@gmail.com>
|
I've attempted to update file copyright, at least for the main changes. Please fix as required or provide guidance and I will make any required changes. |
|
Oops, this is probably a near-duplicate of PR #12079. |
|
https://github.com/prusa3d/PrusaSlicer/releases/tag/version_2.7.3-alpha1 says it was merged... somehow by this commit 122d876 |
|
Closing as effectively merged in https://github.com/prusa3d/PrusaSlicer/releases/tag/version_2.7.3-alpha1 by 122d876. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the original PR for details.
Update: also fixes #7932.
According to the original PR:
Ported from commits:
SoftFever/OrcaSlicer@9acd550 SoftFever/OrcaSlicer@522b848
Original commit messages:
Original commits authored by Andrew Boktor aboktor@microsoft.com, SoftFever softfeverever@gmail.com